Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system tests: podman-remote, image tree #7238

Merged
merged 1 commit into from
Aug 10, 2020
Merged

system tests: podman-remote, image tree #7238

merged 1 commit into from
Aug 10, 2020

Conversation

edsantiago
Copy link
Member

  • new sanity checks for podman-remote:

    • first, confirm that when PODMAN is "-remote",
      we actually talk to a server (validated by
      presence of "Server:" string in "podman version").
    • second, add test for Refactor parsing to not require --remote to be first flag #7212, in which we run
      "podman --remote" (podman with --remote flag,
      not podman-remote command) and make sure --remote
      is allowed both as the first option and also
      with other flag options preceding.

  • new test for "podman image tree" (piggybacking on
    top of a "podman build" test, because that gives
    us lots of layers).

Signed-off-by: Ed Santiago santiago@redhat.com

@rhatdan
Copy link
Member

rhatdan commented Aug 5, 2020

/approve
LGTM

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2020
@edsantiago
Copy link
Member Author

Restarted fedora-32, it's the cgroup.freeze flake (#7148)

@edsantiago edsantiago mentioned this pull request Aug 5, 2020
Closed
@edsantiago
Copy link
Member Author

/hold

Seeing a huge number of #7241 flakes. I'm just trying to gather data right now.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 6, 2020
@edsantiago
system tests: podman-remote, image tree
3c880a9 
- new sanity checks for podman-remote:
  - first, confirm that when PODMAN is "-remote",
    we actually talk to a server (validated by
    presence of "Server:" string in "podman version").
  - second, add test for containers#7212, in which we run
    "podman --remote" (podman with --remote flag,
    not podman-remote command) and make sure --remote
    is allowed both as the first option and also
    with other flag options preceding.

- new test for "podman image tree" (piggybacking on
  top of a "podman build" test, because that gives
  us lots of layers).

- skip "podman exec - basic test" when remote. It is consistently
  causing CI failures, breaking all of CI, due to containers#7241.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@edsantiago
Copy link
Member Author

Tests green. I added a skip for one particular test that is triggering #7241 in CI, and causing pretty much every PR to fail CI. If we merge this, then rebase every PR, I think we'll be able to move on.

@edsantiago
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2020
@mheon
Copy link
Member

mheon commented Aug 10, 2020

/approve
LGTM
@baude @vrothberg @rhatdan PTAL, let's get this merged to fix CI.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, mheon, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Aug 10, 2020

Oh, Dan already dropped an LGTM. Let's merge.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit da00482 into containers:master Aug 10, 2020
@edsantiago edsantiago mentioned this pull request Aug 19, 2020
Closed
@Luap99 Luap99 mentioned this pull request Aug 30, 2020
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@edsantiago @rhatdan @mheon @openshift-ci-robot @openshift-merge-robot