podman-remote send name and tag

[baude]

when loading an image with podman-remote load, we need to send a name and a tag to the endpoint

Fixes: #7124

Signed-off-by: Brent Baude bbaude@redhat.com

[baude]

@cevich i think you were looking for a failure like i am seeing?

[rhatdan]

LGTM

[vrothberg]

Changes LGTM.

Before we merge: @edsantiago is there a system test we can enable for this one? I started to become pedantic for fixes without a test change.

[edsantiago]

$ ack 7124 test/system/*.bats
test/system/120-load.bats
80:    skip_if_remote "FIXME: pending #7124"

[edsantiago]

It's not working, though:

$ ./bin/podman-remote pull alpine
a24bb4013296f61e89ba57005a7b3e52274d8edd3ae2077d04395f806b63d83e
$ ./bin/podman-remote save a24bb401 -o /tmp/alpine.tar
 $ ./bin/podman-remote rmi a24bb401
Untagged: docker.io/library/alpine:latest
Deleted: a24bb4013296f61e89ba57005a7b3e52274d8edd3ae2077d04395f806b63d83e
$ ./bin/podman-remote load -i /tmp/alpine.tar hellothere
Error: invalid reference format
$ echo $?
125

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [baude]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[edsantiago]

Weird... looks like podman run -d hung:

[+0440s] not ok 50 podman pause/unpause
         # (from function `run_podman' in file test/system/helpers.bash, line 164,
         #  in test file test/system/080-pause.bats, line 12)
         #   `run_podman run -d --name $cname $IMAGE \' failed with status 124
         # # podman-remote --url unix:/tmp/podman.xV37qa rm --all --force
         # # podman-remote --url unix:/tmp/podman.xV37qa images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
         # quay.io/libpod/alpine_labels:latest 4fab981df737
         # # podman-remote --url unix:/tmp/podman.xV37qa run -d --name gV2iFMgYSu quay.io/libpod/alpine_labels:latest sh -c while :;do date +%s;sleep 1;done
         # 2065d55236e4ab989ba3010c7364cd54abf4bcf72571515df661df5ba105e1af
         # timeout: sending signal TERM to command ‘/var/tmp/go/src/github.com/containers/podman/bin/podman-remote’
         # timeout: sending signal KILL to command ‘/var/tmp/go/src/github.com/containers/podman/bin/podman-remote’
         # [ rc=124 (** EXPECTED 0 **) ]
         # *** TIMED OUT ***

(full log).

I'm assuming it's a flake, and have restarted the test. I have a feeling I'll be filing an issue about this soon.

[edsantiago]

/lgtm