Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: force registry:2.6 #6684

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

vrothberg
Copy link
Member

@vrothberg vrothberg commented Jun 19, 2020

Force using the registry:2.6 image. 2.7 and beyond dropped the
htpasswd binary from the rootfs which parts of our CI depends
on.

While this is not a sustainable solution (assuming htpasswd is gone
for ever), it unblocks the CI for now.

Signed-off-by: Valentin Rothberg rothberg@redhat.com

For using the `registry:2.6` image. 2.7 and beyond dropped the
`htpasswd` binary from the rootfs which parts of our CI depends
on.

While this is not a sustainable solution (assuming `htpasswd` is gone
for ever), it unblocks the CI for now.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2020
@vrothberg
Copy link
Member Author

FYI @baude @mheon

@rhatdan
Copy link
Member

rhatdan commented Jun 19, 2020

LGTM
Need to figure out a long term solution.

@edsantiago
Copy link
Member

LGTM. Thank you for tracking that down.

@rhatdan
Copy link
Member

rhatdan commented Jun 19, 2020

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2020
@vrothberg
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
@openshift-merge-robot openshift-merge-robot merged commit 5ec29f8 into containers:master Jun 19, 2020
@vrothberg vrothberg deleted the fix-ci branch June 19, 2020 12:45
@TomSweeneyRedHat
Copy link
Member

@cevich FYI

@edsantiago
Copy link
Member

assuming htpasswd is gone for ever

FWIW their own documentation describes the use of htpasswd in their container. It is hard to imagine that we are the only ones impacted by this.

@mheon
Copy link
Member

mheon commented Jun 22, 2020

@vrothberg FYI we probably need a backport of this to the v1.9 branch, in case we ever need to do further backports there

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants