fork https://github.com/abitrolly/podman #3772
Conversation
haircommander
force-pushed
the
snapcraft
branch
2 times, most recently
from
af3ac12
to
1530b17
Compare
|
@haircommander git validation is not your friend here |
haircommander
force-pushed
the
snapcraft
branch
from
1530b17
to
8d04c80
Compare
|
🤞 |
contrib/snapcraft/README.md
Outdated
| <br /> | ||
| </h1> | ||
|
|
||
| <p align="center"><b>This is the snap for <a href="https://podman.io/">podman</a></b>, <i>“Managing Pods, Containers, and Container Images in Multiple Formats (Docker, OCI, ...).”</i>. It works on Ubuntu, Fedora, Debian, and other major Linux |
There was a problem hiding this comment.
Can we mention RHEL and/or SUSE here?
|
LGTM |
|
@TomSweeneyRedHat as far as I can tell, this is a WIP. @abitrolly is that correct? |
|
Yes, it is a WIP. It might even require some hacks on When building with a very old version of |
|
Hi @abitrolly, most of the bugs you're experiencing were fixed in snapcraft 3.o or later. When building the snap make to follow these steps for prep. Prepsudo snap install snapcraft --classic |
|
@mikeroyal I run |
|
We need @mikeroyal @abitrolly @lsm5 @jnovy To approve this PR. since I have no knowlege of how Snap works. Can we merge this into libpod and then automatically get snaps to build and be installable on Ubuntu and Debian distros? |
| source: https://github.com/containers/libpod/archive/v0.11.1.1.tar.gz | ||
| go-importpath: github.com/containers/libpod | ||
| build-packages: | ||
| # https://github.com/containers/libpod/blob/master/install.md#build-and-run-dependencies |
There was a problem hiding this comment.
Used this snapcraft.yaml to build it:
# snapcraft --debug
...
The 'podman' part is missing libraries that are not included in the snap or base. They can be satisfied by adding the following entry for this part
stage-packages:
- libarchive13
- libassuan0
- libgpgme11
- libicu60
- libostree-1-1
- libsoup2.4-1
- libxml2
'grade' property not specified: defaulting to 'stable'
Snapping 'podman' /
Snapped podman_0.11.1.1_amd64.snap
# ls -l
total 28640
-rw-r--r--. 1 root root 29323264 Aug 12 15:28 podman_0.11.1.1_amd64.snap
-rw-r--r--. 1 root root 1134 Aug 12 15:24 snapcraft.yaml
Should we add the stage-packages entry there as well?
There was a problem hiding this comment.
@jnovy most likely podman snap won't work without them if you install and try the snap.
There was a problem hiding this comment.
Hi @jnovy,
The 'stage-packages:' should be placed right below the 'build-packages:'
There was a problem hiding this comment.
Added the missing stage-packages to snapcraft.yaml.
There was a problem hiding this comment.
thanks for adding that @jnovy , I squashed the commits to fix the validate problem :)
There was a problem hiding this comment.
lgtm now - @mheon - Could you merge this please?
by forking https://github.com/abitrolly/podman Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Jindrich Novy <jnovy@redhat.com>
haircommander
force-pushed
the
snapcraft
branch
from
43e3b74
to
e9365c1
Compare
|
PTAL @mikeroyal @abitrolly |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haircommander, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
LGTM, but would like a mheon head nod. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
per conversation in #1915
Signed-off-by: Peter Hunt pehunt@redhat.com