Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec: simplify handling of --ulimit host #3583

Merged
merged 1 commit into from
Jul 17, 2019
Merged

spec: simplify handling of --ulimit host #3583

merged 1 commit into from
Jul 17, 2019

Conversation

giuseppe
Copy link
Member

it seems enough to not specify any ulimit block to maintain the host
limits.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M labels Jul 16, 2019
@giuseppe giuseppe mentioned this pull request Jul 16, 2019
Merged
@mheon
Copy link
Member

mheon commented Jul 16, 2019

I'm always in favor of simplification... LGTM, but your tests are red

@rhatdan
Copy link
Member

rhatdan commented Jul 16, 2019

LGTM

@giuseppe
spec: rework --ulimit host
2f0ed53 
it seems enough to not specify any ulimit block to maintain the host
limits.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
vrothberg
vrothberg reviewed Jul 17, 2019
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe, the only diff I found with the hosts limit is the soft limit for open files (host=1024, ctr=524288=hard limit). The behaviour is the same prior to this change.

@giuseppe
Copy link
Member Author

@giuseppe, the only diff I found with the hosts limit is the soft limit for open files (host=1024, ctr=524288=hard limit). The behaviour is the same prior to this change.

that happens because we bump immediately the limit in main_local.go.

@baude
Copy link
Member

baude commented Jul 17, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2019
@openshift-merge-robot openshift-merge-robot merged commit 1c02905 into containers:master Jul 17, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@jwhonce jwhonce Awaiting requested review from jwhonce

@umohnani8 umohnani8 Awaiting requested review from umohnani8

Assignees

@baude baude

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@giuseppe @openshift-ci-robot @mheon @rhatdan @baude @vrothberg @openshift-merge-robot