-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support running containers without CGroups #3581
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -122,6 +122,10 @@ runtime = "runc" | |
# libpod will use it for reporting nicer errors. | ||
runtime_supports_json = ["crun", "runc"] | ||
|
||
# List of all the OCI runtimes that support --cgroup-manager=disable to disable | ||
# creation of CGroups for containers. | ||
runtime_supports_nocgroups = ["crun"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yuck, this is getting to complicated. I would rather throw an error, or see what runc throws for an error when called in this way There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We do this for other OCI runtime features. I think it's a better user experience that popping up errors from There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I share Dan's initial reaction but as we're already doing it for other features (see json-support above), I prefer doing that to be consistent. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. However, it's not the best experience for package updates/upgrades as the |
||
|
||
# Paths to look for a valid OCI runtime (runc, runv, etc) | ||
# If the paths are empty or no valid path was found, then the `$PATH` | ||
# environment variable will be used as the fallback. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment does not match the above --no-cgroups, although I prefer --cgroupns=none.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OCI runtime command that needs to be supported is
--cgroup-manager=disable
(or at least, it is oncrun
- we'll see whatrunc
has to say.