-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves STD output/readability in combination #3530
Improves STD output/readability in combination #3530
Conversation
Hi @deefin. Thanks for your PR. I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @deefin
bot, test pull request |
/ok-to-test |
This LGTM |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deefin, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@deefin Can you rebase? There's a fix for the tests on master |
☔ The latest upstream changes (presumably #3521) made this pull request unmergeable. Please resolve the merge conflicts. |
/ok-to-test |
@deefin you need to rebase your PR. git pull origin master Then we can merge. |
☔ The latest upstream changes (presumably #3537) made this pull request unmergeable. Please resolve the merge conflicts. |
@rhatdan Thanks, I previously just tried to merge as seen below:
In respect the below config:
Should the commands you gave me be?
|
Generally I use |
with debug output. Added \n char to specific standard output Signed-off-by: dom finn <dom.finn00@gmail.com>
Thanks @mheon. Please excuse my giteracy (git literacy) Its looking better now from what i can see. |
/lgtm |
Improves standard output with debug output.
Added \n char to specific standard output
Closes #3490
Signed-off-by: dom finn dom.finn00@gmail.com