Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomize IP addresses during checkpoint/restore tests #3501

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Randomize IP addresses during checkpoint/restore tests #3501

merged 1 commit into from
Jul 9, 2019

Conversation

adrianreber
Copy link
Collaborator

@adrianreber adrianreber commented Jul 4, 2019 •
edited
Loading

There have been CI failures with some checkpoint/restore tests which could be related to running tests in parallel and using the same IP address.

This tries to run all (almost) checkpoint/restore tests with random IP addresses.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2019
@rh-atomic-bot
Copy link
Collaborator

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@adrianreber
Copy link
Collaborator Author

Looks pretty good on the first try, no checkpoint/restore related failures. Let's try a second time.

@adrianreber
Copy link
Collaborator Author

Second CI run also without errors.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #3496) made this pull request unmergeable. Please resolve the merge conflicts.

@adrianreber
Use random IP addresses during checkpoint/restore tests
d0f540e 
This tries to reduce CI errors which might happen due to parallel CI
runs which all are using the same IP addresses. Using random addresses
should reduce the possibility of parallel tests using the same IP address.

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber adrianreber changed the title [WIP] Test if randomizing IP addresses during checkpoint/restore tests is a good idea Randomize IP addresses during checkpoint/restore tests Jul 9, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2019
@adrianreber
Copy link
Collaborator Author

Rebased, repushed and removed WIP from title. Not sure if this actually makes sense or if it is a useless optimization. The first two CI runs looked pretty good, not sure if I am just lucky.

@rhatdan
Copy link
Member

rhatdan commented Jul 9, 2019

LGTM
@vrothberg @giuseppe @mheon @baude @ashley-cui @QiWang19 PTAL

@mheon
Copy link
Member

mheon commented Jul 9, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianreber, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 5786a3a into containers:master Jul 9, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 26, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrunalp mrunalp Awaiting requested review from mrunalp

@vrothberg vrothberg Awaiting requested review from vrothberg

Assignees

@mheon mheon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adrianreber @rh-atomic-bot @rhatdan @mheon @openshift-ci-robot @openshift-merge-robot