Update registrar unit tests to match them of cri-o

[saschagrunert]

Hey, I basically copied the registrar tests from cri-o over here including their dependencies:

• Add the test framework abstraction
• Update the unit tests to run with ginkgo

As a follow-up I would remove the registrar completely from cri-o and use libpods' one.

Another general improvement could be to utilize the already vendored ginkgo sources for running the tests, like we do in cri-o:

${BUILD_BIN_PATH}/ginkgo:
	$(GO) build -o ${BUILD_BIN_PATH}/ginkgo ./vendor/github.com/onsi/ginkgo/ginkgo

testunit: mockgen ${BUILD_BIN_PATH}/ginkgo
	${BUILD_BIN_PATH}/ginkgo \
		${TESTFLAGS} \
		-r \
		...

This would make the test results more reliable.

[openshift-ci-robot]

Hi @saschagrunert. Thanks for your PR.

I'm waiting for a containers or openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[saschagrunert]

Hm, the issue with the CI looks like a bug in ginkgo: onsi/ginkgo#427 🤔

[saschagrunert]

/hold

[baude]

why do we need this?

[saschagrunert]

why do we need this?

The unit tests for this package have been upgraded within cri-o to use ginkgo/gomega (higher test coverage and bdd style). I thought it would be nice to have them here as well, since cri-o could rely completely on the package within libpod and remove its own copy of the code.

[rhatdan]

Tests are not working...

[saschagrunert]

I had to exclude the pkg/apparmor tests until onsi/ginkgo#570 is not merged yet. This makes me not happy at all, WDYT? If you tend to not go this way here I would also be fine in closing this PR.

[saschagrunert]

/hold cancel

[vrothberg]

I had to exclude the pkg/apparmor tests until onsi/ginkgo#570 is not merged yet. This makes me not happy at all, WDYT? If you tend to not go this way here I would also be fine in closing this PR.

Personally, I find the standard testing package to be much easier to brain-parse, read and maintain but I don't have much experience in the other packages and usually copy-pasted my way through. But the decision is entirely up to @baude and @mheon.

[mheon]

LGTM
@baude @vrothberg @rhatdan PTAL

[mheon]

/ok-to-test
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

/lgtm