Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 330-corrupt-images.bats for composefs behavior change #24314

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 18, 2024

With containers/storage#2118 and containers/image#2589 , the convert_images (i.e. “disallow non-partial pulls”) option fails with VFS.

The 330-corrupt-images tests were temporarily switching to VFS, possibly within a composefs test run with convert_images set, without disabling it. That is going to fail after we update c/image and c/storage; update the tests for the changed behavior.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none labels Oct 18, 2024
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtrmac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 18, 2024
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@mtrmac
Copy link
Collaborator Author

mtrmac commented Oct 18, 2024

@edsantiago This is a composefs feature/change change, not quite zstd:chunked related, so filing in a separate PR. And this test update will be necessary to support current c/storage + c/image even if we don’t switch to chunked images.

50da568 shows tests failing with current c/storage + c/image and no other modification.

17685d1 shows the tests passing with current c/storage + c/image, and a test update.

This PR now contains only the test update, as proven by the two test runs above.

@mtrmac mtrmac changed the title WIP: composefs enforcing vs. VFS test Fix 330-corrupt-images.bats in composefs test runs Oct 18, 2024
@mtrmac mtrmac marked this pull request as ready for review October 18, 2024 21:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2024
@mtrmac mtrmac changed the title Fix 330-corrupt-images.bats in composefs test runs Update 330-corrupt-images.bats for composefs behavior change Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant