libpod: change the default rootless cgroup path parent #24301
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rpigott The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rpigott
force-pushed
the
default-cgoru-path
branch
from
f2345b9
to
cfcb177
Compare
rpigott
changed the title
rpigott
force-pushed
the
default-cgoru-path
branch
from
cfcb177
to
1cb344d
Compare
|
@giuseppe PTAL |
giuseppe
added
the
No New Tests
|
there is no particular reason for using Please adjust all the other occurrences of |
user.slice is a poor choice of slice name to put containers in. There is no direct conflict with the system user.slice, but it may still be easily confused by humans and isn't descriptive of its purpose. After user.slice, user-$UID.slice, user@$uid.service, we don't need another user.slice if we can avoid it. Let's change user.slice to container.slice to better represent its usage and help disambiguate it from a slew of user cgroups. Signed-off-by: Ronan Pigott <ronan@rjp.ie>
rpigott
force-pushed
the
default-cgoru-path
branch
from
1cb344d
to
01f520b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user.slice is a poor choice of slice name to put containers in. There is no direct conflict with the system user.slice, but it may still be easily confused by humans and isn't descriptive of its purpose. After user.slice, user-$UID.slice, user@$uid.service, we don't need another user.slice if we can avoid it.
Let's change user.slice to containers.slice to better represent its usage and help disambiguate it from a slew of user cgroups.
Does this PR introduce a user-facing change?