Support filter image by reference to the image name #2430
Conversation
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
needs an integration test or two/ else lgtm |
|
ditto @baude's comment. LGTM once new tests are provided. |
|
@QiWang19 and I just did a lot of rework on this one. She will be pushing a new PR along with tests. |
QiWang19
changed the title
| if podmanTest.RemoteTest { | ||
| Skip("Does not work on remote client") | ||
| } | ||
| result := podmanTest.Podman([]string{"images", "-q", "-f", "reference=docker.io*"}) |
There was a problem hiding this comment.
Lets add a couple of others.
Look for only alpine, make sure you get one
Look for a*pine a make sure you get one.
and look for bogus. and make sure you get none.
|
Needs to update RELEASE_NOTES.md with changes |
|
Nevermind the noise, no need to hit the release notes doc |
QiWang19
force-pushed
the
issfiltet
branch
2 times, most recently
from
b85b938 to
a7a07a2
Compare
Signed-off-by: Qi Wang <qiwan@redhat.com>
|
@QiWang19 Did you add tests? |
|
@rhatdan added tests. Ready to be merged. |
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
fix #2266
Signed-off-by: Qi Wang qiwan@redhat.com