use slices.Clone instead of assignment #24284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containers#24267 This commit replaces a potentially unsafe slice-assignment with a call to `slices.Clone`. This could prevent a bug where `saveCommand` and `loadCommand` could end up sharing an underlying array if `parentFlags` has a cap > it's len. Signed-off-by: Zachary Hanham <z.hanham00@gmail.com>
|
Ephemeral COPR build failed. @containers/packit-build please check. |
rhatdan
added
the
No New Tests
|
Thanks @zackattackz |
|
/approve |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan, zackattackz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit bd1abf0
into
containers:main
76 of 78 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24267
This commit replaces a potentially unsafe slice-assignment with a call to
slices.Clone.This could prevent a bug where
saveCommandandloadCommandcould end up sharing an underlying array ifparentFlagshas a cap > it's len.I did not write/change any tests for this PR, because it seems like a small enough change to be OK and because a test for this would be seem strange on the surface (passing in
parentFlagswith a cap > it's len to see if it causes issues). But if a test is needed I could amend one in at request.Also, there could be other places in the code that could use this change, but I did not check. Some kind of linter for this would be ideal. gocritic did not seem to catch this when I checked.
Does this PR introduce a user-facing change?