Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pod: drop invalid check for rootless #2308

Merged
merged 2 commits into from
Feb 11, 2019
Merged

pod: drop invalid check for rootless #2308

merged 2 commits into from
Feb 11, 2019

Conversation

giuseppe
Copy link
Member

rootless networks support port binding if the underlying slirp4netns
is new enough.

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

@giuseppe
pod: drop not valid check for rootless
585f296 
rootless networks support port binding if the underlying slirp4netns
is new enough.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS labels Feb 11, 2019
@giuseppe giuseppe changed the title pod: drop not valid check for rootless pod: drop invalid check for rootless Feb 11, 2019
@giuseppe
oci: do not set XDG_RUNTIME_DIR twice
41967e2 
we are doing it few lines above.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Feb 11, 2019

LGTM
@mheon @vrothberg @TomSweeneyRedHat @umohnani8 @baude PTAL

vrothberg
vrothberg reviewed Feb 11, 2019
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@giuseppe do we document the min version of slirp4netns somewhere? I am just thinking about where packagers can get this information. (Cc @mheon for changelog)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2019
@openshift-merge-robot openshift-merge-robot merged commit acf2e91 into containers:master Feb 11, 2019
@giuseppe
Copy link
Member Author

we have a comment in f182946.

0.3 will be released soon, so we can point the rpm packages to it

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@giuseppe @openshift-ci-robot @rhatdan @vrothberg @openshift-merge-robot