Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:BUILD] rpm: bump podman module version #21584

Merged
merged 1 commit into from
Feb 9, 2024
Merged

[CI:BUILD] rpm: bump podman module version #21584

merged 1 commit into from
Feb 9, 2024

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Feb 9, 2024

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 9, 2024
@lsm5
Copy link
Member Author

lsm5 commented Feb 9, 2024

@Luap99 @mheon PTAL

Luap99
Luap99 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vrothberg
vrothberg approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Feb 9, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Luap99,lsm5,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
[CI:BUILD] rpm: bump podman module version
4413e75 
[NO NEW TESTS NEEDED]

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@lsm5
Copy link
Member Author

lsm5 commented Feb 9, 2024

/lgtm /hold

@vrothberg please redo it, I had to add the no new tests needed and repush. thanks!

@Luap99
Copy link
Member

Luap99 commented Feb 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@Luap99
Copy link
Member

Luap99 commented Feb 9, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d6ddd9f into containers:main Feb 9, 2024
37 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 10, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg approved these changes

@Luap99 Luap99 Luap99 approved these changes

Assignees

@vrothberg vrothberg

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lsm5 @Luap99 @vrothberg