Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tmpfs mounts when creating a memory-backed emptyDir volume #21524

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Use tmpfs mounts when creating a memory-backed emptyDir volume #21524

merged 1 commit into from
Feb 7, 2024

Conversation

andremarianiello
Copy link
Contributor

Implements #21367

Does this PR introduce a user-facing change?

Added support for memory-backed emptyDir volumes to `podman play kube`. Example:

- name: "myvolume"
  emptyDir:
    medium: "Memory"

@openshift-ci openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Feb 5, 2024
@andremarianiello
Use tmpfs mounts when creating a memory-backed emptyDir volume
d3281cf 
Signed-off-by: Andre Marianiello <andremarianiello@users.noreply.github.com>
@andremarianiello andremarianiello marked this pull request as ready for review February 6, 2024 19:24
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 6, 2024
@andremarianiello
Copy link
Contributor Author

CI failures look unrelated to my changes, but I don't see how to retry the jobs. Any suggestions?

@rhatdan
Copy link
Member

rhatdan commented Feb 6, 2024

LGTM
Thanks @andremarianiello
@ygalblum @haircommander @saschagrunert @umohnani8 PTAL

ygalblum
ygalblum reviewed Feb 7, 2024
View reviewed changes
Copy link
Contributor

@ygalblum ygalblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andremarianiello, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 6b592bd into containers:main Feb 7, 2024
91 of 92 checks passed
@Luap99 Luap99 mentioned this pull request Feb 8, 2024
Closed
@edsantiago edsantiago mentioned this pull request Feb 8, 2024
Closed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label May 8, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ygalblum ygalblum ygalblum left review comments

Assignees

@ygalblum ygalblum

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andremarianiello @rhatdan @ygalblum