Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/ISSUE_TEMPLATE: Suggest '/kind bug' and '/kind feature' #2087

Merged
merged 1 commit into from
Jan 9, 2019
Merged

.github/ISSUE_TEMPLATE: Suggest '/kind bug' and '/kind feature' #2087

merged 1 commit into from
Jan 9, 2019

Conversation

wking
Copy link
Contributor

@wking wking commented Jan 5, 2019

So Prow's label plugin can apply the appropriate label for us.

/kind feature

For an example, of /kind bug working, see here.

@openshift-ci-robot openshift-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS labels Jan 5, 2019
mheon
mheon reviewed Jan 5, 2019
View reviewed changes
.github/ISSUE_TEMPLATE.md

[//]: # Uncomment only one, leave it on its own line:
/kind bug
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will the bot do if both are present? Add both labels?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will the bot do if both are present? Add both labels?

Yeah, probably. Do you expect cleaning up after that to be more or less work than just adding the labels yourself? ;)

@mheon
Copy link
Member

mheon commented Jan 5, 2019

Our CI is a bit of a mess right now, after a messy merge on Friday. Looking to have it cleaned up Monday, so you'll probably be asked to rebase then.

@mheon
Copy link
Member

mheon commented Jan 7, 2019

@wking Mind rebasing to pick up CI fixes?

@wking
Copy link
Contributor Author

wking commented Jan 9, 2019 •
edited
Loading

Mind rebasing to pick up CI fixes?

Rebased onto master (no conflicts) with 336b2c2 -> 3018e72.

@wking
.github/ISSUE_TEMPLATE: Suggest '/kind bug' and '/kind feature'
3018e72 
So Prow's label plugin [1] can apply the appropriate label for us.

[1] https://github.com/kubernetes/test-infra/tree/master/prow/plugins/label

Signed-off-by: W. Trevor King <wking@tremily.us>
@vrothberg
Copy link
Member

/approve

Thanks, @wking! @mheon can you lgtm to merge?

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2019
@rhatdan
Copy link
Member

rhatdan commented Jan 9, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2019
@openshift-merge-robot openshift-merge-robot merged commit 5061081 into containers:master Jan 9, 2019
@wking wking deleted the kind-bug branch February 5, 2019 00:42
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mheon mheon mheon left review comments

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wking @mheon @vrothberg @openshift-ci-robot @rhatdan @openshift-merge-robot