Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

container: always check if mountpoint is mounted #20299

Merged
merged 2 commits into from
Oct 9, 2023
Merged

container: always check if mountpoint is mounted #20299

merged 2 commits into from
Oct 9, 2023

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Oct 7, 2023

when running as a service, the c.state.Mounted flag could get out of sync if the container is cleaned up through the cleanup process.

To avoid this, always check if the mountpoint is really present before skipping the mount.

Closes: #17042

Does this PR introduce a user-facing change?

fix a race condition where a container restarted by the Podman daemon doesn't mount its storage

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2023
@giuseppe giuseppe mentioned this pull request Oct 7, 2023
Closed
@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@edsantiago
Copy link
Member

Thank you for persevering on this! Please don't lose your weekend over it, though.

@giuseppe giuseppe marked this pull request as draft October 8, 2023 08:18
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2023
@giuseppe giuseppe marked this pull request as ready for review October 8, 2023 20:06
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 8, 2023
@edsantiago
Copy link
Member

I keep seeing re-pushes but I don't see any difference in the new push. I think you're missing something?

@giuseppe
vendor: update c/storage
9beb3a9 
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

giuseppe commented Oct 9, 2023

I keep seeing re-pushes but I don't see any difference in the new push. I think you're missing something?

I wanted to test the PR better since it is a flake. I am analyzing the integration tests failures now

@giuseppe
container: always check if mountpoint is mounted
8ac2aa7 
when running as a service, the c.state.Mounted flag could get out of
sync if the container is cleaned up through the cleanup process.

To avoid this, always check if the mountpoint is really present before
skipping the mount.

[NO NEW TESTS NEEDED]

Closes: containers#17042

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@mheon
Copy link
Member

mheon commented Oct 9, 2023

Code LGTM

@mheon
Copy link
Member

mheon commented Oct 9, 2023

I think we can ignore the RPM failures?

@rhatdan
Copy link
Member

rhatdan commented Oct 9, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@openshift-ci openshift-ci bot merged commit 8615b16 into containers:main Oct 9, 2023
96 of 98 checks passed
@edsantiago edsantiago mentioned this pull request Oct 10, 2023
Closed
@edsantiago edsantiago mentioned this pull request Oct 23, 2023
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

executable file /catatonit [et al] not found in $PATH: No such file or directory
4 participants
@giuseppe @edsantiago @mheon @rhatdan