-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sha256: to images history id for docker compatibility #18327
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -33,13 +33,18 @@ func HistoryImage(w http.ResponseWriter, r *http.Request) { | |||
allHistory := make([]handlers.HistoryResponse, 0, len(history)) | |||
for _, h := range history { | |||
l := handlers.HistoryResponse{ | |||
ID: h.ID, | |||
ID: "sha256:" + h.ID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line can be removed to avoid redundancy with the new if-else below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my mind it was removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: containers#17762 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Fixes: #17762
Does this PR introduce a user-facing change?