Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Skip all pasta tests" #17650

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Revert "Skip all pasta tests" #17650

merged 2 commits into from
Feb 28, 2023

Conversation

sbrivio-rh
Copy link
Collaborator

@sbrivio-rh sbrivio-rh commented Feb 28, 2023

This reverts commit 81f116c: the passt package for Fedora 37 images is now fixed in the c20230223t153813z-f37f36d12 image.

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Feb 28, 2023
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, sbrivio-rh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@sbrivio-rh
Copy link
Collaborator Author

There's probably some other issue here, checking versions etc.

@sbrivio-rh sbrivio-rh changed the title Revert "Skip all pasta tests" WIP: Revert "Skip all pasta tests" Feb 28, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
@sbrivio-rh
Copy link
Collaborator Author

@cevich the version of passt here is passt-0^20230216.g4663ccc-1.fc37-x86_64, instead of passt-0^20230222.g4ddbcb9-1.fc37, but c20230223t153813z-f37f36d12 is the IMAGE_SUFFIX in .cirrus.yml as you indicated. What am I doing wrong?

@sbrivio-rh
Copy link
Collaborator Author

@cevich the version of passt here is passt-0^20230216.g4663ccc-1.fc37-x86_64, instead of passt-0^20230222.g4ddbcb9-1.fc37, but c20230223t153813z-f37f36d12 is the IMAGE_SUFFIX in .cirrus.yml as you indicated. What am I doing wrong?

Never mind, my bad, I didn't commit that change.

They include passt-0^20230222.g4ddbcb9-1.fc37, so that we can
re-enable pasta tests, and passt-0.0~git20230216.4663ccc-1, so that
we can run them on Debian Sid.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This reverts commit 81f116c: the
passt package for Fedora 37 images is now fixed in the
c20230223t153813z-f37f36d12 image.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2023
@rhatdan
Copy link
Member

rhatdan commented Feb 28, 2023

Please remove WIP from heading if this is ready to merge.

@sbrivio-rh
Copy link
Collaborator Author

@Luap99 I guess you retriggered the "sys podman debian-12 rootless host" test, thanks! That failed twice with:

[+1305s] ok 497 podman networking with pasta(1) - UDP/IPv4 large transfer, tap
[11:59:07] END - [+1548s] total duration since 2023-02-28T11:59:07
Exit status: 2

...are the tests triggering a more general timeout, not for the specific test case? Let me know if there's anything I can debug.

Needless to say, I can consistently run these tests on current Debian Bookworm (current testing) with Podman and passt packages from Sid (unstable). :(

@sbrivio-rh
Copy link
Collaborator Author

sbrivio-rh commented Feb 28, 2023

@Luap99 I guess you retriggered the "sys podman debian-12 rootless host" test, thanks! That failed twice with:

[+1305s] ok 497 podman networking with pasta(1) - UDP/IPv4 large transfer, tap
[11:59:07] END - [+1548s] total duration since 2023-02-28T11:59:07
Exit status: 2

...are the tests triggering a more general timeout, not for the specific test case? Let me know if there's anything I can debug.

Needless to say, I can consistently run these tests on current Debian Bookworm (current testing) with Podman and passt packages from Sid (unstable). :(

Sorry, not my day. The re-run actually passed, I was following the wrong link.

@sbrivio-rh
Copy link
Collaborator Author

Please remove WIP from heading if this is ready to merge.

@rhatdan sure, I'm just waiting for a couple of tests to finish.

@sbrivio-rh sbrivio-rh changed the title WIP: Revert "Skip all pasta tests" Revert "Skip all pasta tests" Feb 28, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2023
@Luap99
Copy link
Member

Luap99 commented Feb 28, 2023

I rerun "sys podman debian-12 rootless host" because of this error:

[+0683s] # (from function `is' in file test/system/helpers.bash, line 711,
[+0683s] #  in test file test/system/070-build.bats, line 957)
[+0683s] #   `is "$output"   "$dinode"   "COPY hardlinks work"' failed
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman rm -t 0 --all --force --ignore
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman ps --all --external --format {{.ID}} {{.Names}}
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman images --all --format {{.Repository}}:{{.Tag}} {{.ID}}
[+0683s] # quay.io/libpod/testimage:20221018 f5a99120db64
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman build -t build_test /tmp/podman_bats.OtAdAJ/build-test
[+0683s] # STEP 1/2: FROM quay.io/libpod/testimage:20221018
[+0683s] # STEP 2/2: COPY . /test
[+0683s] # COMMIT build_test
[+0683s] # --> 56f6defabb1
[+0683s] # Successfully tagged localhost/build_test:latest
[+0683s] # 56f6defabb1556f7c555c0fd35bb01e723763f3033e7f5cca2b867dc36ef459a
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman run --rm build_test stat -c %i /test/Dockerfile
[+0683s] # 530185
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman run --rm build_test stat -c %i /test/hardlink1
[+0683s] # 530184
[+0683s] # #/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
[+0683s] # #|     FAIL: COPY hardlinks work
[+0683s] # #| expected: '530185'
[+0683s] # #|   actual: '530184'
[+0683s] # #\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman rm -t 0 -a -f
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman rmi -f build_test
[+0683s] # Untagged: localhost/build_test:latest
[+0683s] # Deleted: 56f6defabb1556f7c555c0fd35bb01e723763f3033e7f5cca2b867dc36ef459a
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman image prune -f
[+0683s] # # [teardown]
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman pod rm -t 0 --all --force --ignore
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman rm -t 0 --all --force --ignore
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman network prune --force
[+0683s] # $ /var/tmp/go/src/github.com/containers/podman/bin/podman volume rm -a -f

Seems to be a flake and unrelated to this change so I good with merging, if you saw actual timeouts in the pasta tests we should double check.

@sbrivio-rh
Copy link
Collaborator Author

Seems to be a flake and unrelated to this change so I good with merging, if you saw actual timeouts in the pasta tests we should double check.

No, no timeouts, I just saw a truncated log for a while, in the run you triggered it's all fine.

@Luap99
Copy link
Member

Luap99 commented Feb 28, 2023

ok
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2023
@openshift-merge-robot openshift-merge-robot merged commit a5895e3 into containers:main Feb 28, 2023
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants