Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't output "ago" when container is currently up and running #17251

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix: don't output "ago" when container is currently up and running #17251

merged 1 commit into from
Jan 27, 2023

Conversation

quite
Copy link
Contributor

@quite quite commented Jan 27, 2023

Closes #17250

Does this PR introduce a user-facing change?

Fix `podman ps` STATUS output to say "Up 3 seconds", if the container has been up and running for 3 seconds (removing the word "ago".

@rhatdan
Copy link
Member

rhatdan commented Jan 27, 2023

Thanks @quite
/approve

Could you look at the man pages for ago, and remove it from them as well.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@quite
Copy link
Contributor Author

quite commented Jan 27, 2023

@rhatdan good catch! fixed

vrothberg
vrothberg approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@vrothberg
Copy link
Member

Can you rebase your commit on the latest main branch? This will fix the test issue.

@quite
fix: don't output "ago" when container is currently up and running
497be10 
Closes containers#17250

Signed-off-by: Daniel Lublin <daniel@lublin.se>
@vrothberg
Copy link
Member

@containers/podman-maintainers PTAL

giuseppe
giuseppe approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, quite, rhatdan, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [giuseppe,rhatdan,vrothberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jan 27, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2023
@rhatdan rhatdan added the 4.4 label Jan 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit a096e32 into containers:main Jan 27, 2023
@rhatdan
Copy link
Member

rhatdan commented Jan 27, 2023

/cherrypick v4.4

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 27, 2023
Merged
@openshift-cherrypick-robot
Copy link
Collaborator

@rhatdan: new pull request created: #17255

In response to this:

/cherrypick v4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@edsantiago edsantiago mentioned this pull request Jan 30, 2023
Open
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@vrothberg vrothberg vrothberg approved these changes

Assignees

@giuseppe giuseppe

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: HumanDuration STATUS of running container ("Up") should not contain "ago"
6 participants
@quite @rhatdan @vrothberg @openshift-cherrypick-robot @giuseppe @openshift-merge-robot