Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: running check error when podman is default in wsl #17228

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix: running check error when podman is default in wsl #17228

merged 1 commit into from
Jan 27, 2023

Conversation

shblue21
Copy link
Contributor

@shblue21 shblue21 commented Jan 26, 2023

If podman is set to the wsl default distribution, the (default) value is appended like podman-machine-default (default).

> wsl --list --running
Linux용 Windows 하위 시스템 배포:
podman-machine-default(default)

Because of (default), it determines that podman wsl deployment has not been executed.
It can be solved simply by outputting only the wsl distribution name with the --quiet option.

> wsl --list --running --quiet
podman-machine-default

Related to #17227, #17158

Signed-off-by: shblue21 jihunkimkw@gmail.com

Does this PR introduce a user-facing change?

Fixed a startup issue with podman machine when running under some locales of Windows. 

[NO NEW TESTS NEEDED]

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

In order to pass CI, could you add the magic string [NO NEW TESTS NEEDED] to your commit message and repush?

@n1hility PTAL

@n1hility
Copy link
Member

Thanks for the PR! it looks like this is triggered when running under locales with different spacing rules (the previous code had a faulty assumption the wsl command output would always include a space between the name and the default signifier column).

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 26, 2023
@n1hility
Copy link
Member

I rebased the change with the no tests flag, so once this is green we can merge.

@shblue21
Copy link
Contributor Author

shblue21 commented Jan 27, 2023

@n1hility
Ah, it must have been a locale-specific problem. I didn't know. Thank you
I use podman very usefully.

Thank you for your feedback.

@vrothberg
Copy link
Member

[+1563s] [Fail] Podman play kube [It] podman play kube test with hostIPC
[+1563s] /var/tmp/go/src/github.com/containers/podman/test/e2e/play_kube_test.go:4992

It looks like a bad test was merged earlier. I will look into it.

@vrothberg
Copy link
Member

Please rebase once #17247 got merged and the test will pass again. Sorry for the inconvenience.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n1hility, shblue21, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

If podman is the default wsl distribution, the (default) string is appended and result is assigned false.

[NO NEW TESTS NEEDED]

Fixes #17227

Signed-off-by: shblue21 <jihunkimkw@gmail.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@rhatdan
Copy link
Member

rhatdan commented Jan 27, 2023

/lgtm
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
@rhatdan rhatdan added the 4.4 label Jan 27, 2023
@openshift-merge-robot openshift-merge-robot merged commit b4d169a into containers:main Jan 27, 2023
@rhatdan
Copy link
Member

rhatdan commented Jan 27, 2023

/cherrypick v4.4

@openshift-cherrypick-robot
Copy link
Collaborator

@rhatdan: new pull request created: #17256

In response to this:

/cherrypick v4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@n1hility
Copy link
Member

@shblue21 thanks again for the PR and using podman. We appreciate the help!

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 13, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Does not work if the machine is set to default in wsl.
6 participants