e2e: keeps the http_proxy value #16763
Conversation
In a proxy environment, http_proxy needs to keep the value to use a proxy. Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
| @@ -300,6 +300,11 @@ var _ = Describe("Podman build", func() { | |||
| }) | |||
|
|
|||
| It("podman build --http_proxy flag", func() { | |||
| if env, found := os.LookupEnv("http_proxy"); found { | |||
| defer os.Setenv("http_proxy", env) | |||
There was a problem hiding this comment.
I am not sure it does what you want. Here, the env variable is already set. The defer will set it again but it has not been unset as far as I can see.
There was a problem hiding this comment.
Line 308 in 8b87665
The http_proxy value is overwritten with 1.2.3.4 due to os.Setenv("http_proxy", "1.2.3.4") .
This value needs to revert the original value at this time.
defer os.Setenv("http_proxy", env) reverts the http_proxy to original value.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan, sstosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
locked - please file new issue/PR
In a proxy environment,
http_proxyneeds to keepthe value to use a proxy.
Signed-off-by: Toshiki Sonoda sonoda.toshiki@fujitsu.com
Does this PR introduce a user-facing change?