Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kube sdnotify: run proxies for the lifespan of the service #16709

Merged
merged 2 commits into from
Dec 7, 2022

Commits on Dec 5, 2022

  1. notify k8s system test: move sending message into exec

    The flake in containers#16076 is likely related to the notify message not being
    delivered/read correctly.  Move sending the message into an exec session
    such that flakes will reveal an error message.
    
    Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
    vrothberg committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    8c3af71 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. kube sdnotify: run proxies for the lifespan of the service

    As outlined in containers#16076, a subsequent BARRIER *may* follow the READY
    message sent by a container.  To correctly imitate the behavior of
    systemd's NOTIFY_SOCKET, the notify proxies span up by `kube play` must
    hence process messages for the entirety of the workload.
    
    We know that the workload is done and that all containers and pods have
    exited when the service container exits.  Hence, all proxies are closed
    at that time.
    
    The above changes imply that Podman runs for the entirety of the
    workload and will henceforth act as the MAINPID when running inside of
    systemd.  Prior to this change, the service container acted as the
    MAINPID which is now not possible anymore; Podman would be killed
    immediately on exit of the service container and could not clean up.
    
    The kube template now correctly transitions to in-active instead of
    failed in systemd.
    
    Fixes: containers#16076
    Fixes: containers#16515
    Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
    vrothberg committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    4fa307f View commit details
    Browse the repository at this point in the history