Make released binary names more consistent #16667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at https://github.com/containers/podman/releases/tag/v4.3.1, it's not explicit which arch the podman-remote-static binary is built for, so this commit adds an -$(goarch) suffix to it. It builds both arm64 and amd64 binaries as I need both for crc. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
This is more consistent with the name of the other released files, and makes identification of the binaries easier among the Windows/macOS ones. Related: containers#16612 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
All files released in https://github.com/containers/podman/releases/tag/v4.3.1 use -arm64 for the arch name except podman-installer-macos-aarch64.pkg Related: containers#16612 Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
|
LGTM, but I'd prefer if someone more experienced with Makefiles review before merge. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the name of some of the binaries which go to
https://github.com/containers/podman/releases/
It renames
podman-release-statictopodman-release-static-linux_{amd64,arm64},and renames
podman-installer-macos-aarch64.pkgtopodman-installer-macos-arm64.pkgautomation/scripts relying on these file names which are not stored in
github.com/containers/podman will need to be adjusted for these changes.
This fixes #16612
Does this PR introduce a user-facing change?