Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for podman-remote manifest annotate #16549

Merged

Conversation

sstosh
Copy link
Contributor

@sstosh sstosh commented Nov 18, 2022

Now that podman manifest annotate is supported
in the remote environment.

Signed-off-by: Toshiki Sonoda sonoda.toshiki@fujitsu.com

Does this PR introduce a user-facing change?

Now that podman manifest annotate is supported in the remote environment.

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Nov 18, 2022
@sstosh sstosh changed the title Support podman-remote manifest annotate [WIP] Support podman-remote manifest annotate Nov 18, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2022
@sstosh
Copy link
Contributor Author

sstosh commented Nov 18, 2022

I'll add a swagger documentation next week.

@sstosh sstosh force-pushed the remote-manifest-annotation branch 2 times, most recently from 77b416a to a979274 Compare November 24, 2022 04:38
@sstosh
Copy link
Contributor Author

sstosh commented Nov 24, 2022

I'll add a swagger documentation next week.

manifest annotate is already documented.
https://docs.podman.io/en/latest/_static/api.html#tag/manifests/operation/ManifestModifyLibpod

@sstosh sstosh changed the title [WIP] Support podman-remote manifest annotate Support podman-remote manifest annotate Nov 24, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2022
Now that podman manifest annotate is supported
in the remote environment.

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
@sstosh sstosh changed the title Support podman-remote manifest annotate Add support for podman-remote manifest annotate Nov 24, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@containers/podman-maintainers PTAL

Thanks a lot!

@rhatdan
Copy link
Member

rhatdan commented Dec 12, 2022

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, sstosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@openshift-merge-robot openshift-merge-robot merged commit d8e23df into containers:main Dec 12, 2022
@sstosh sstosh deleted the remote-manifest-annotation branch December 13, 2022 00:24
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 18, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/api-change Change to remote API; merits scrutiny lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants