Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notifyproxy: fix container watcher #16284

Merged
merged 1 commit into from
Oct 25, 2022
Merged

notifyproxy: fix container watcher #16284

merged 1 commit into from
Oct 25, 2022

Commits on Oct 25, 2022

  1. notifyproxy: fix container watcher 

    The notify proxy has a watcher to check whether the container has left
the running state.  In that case, Podman should stop waiting for the
ready message to prevent a dead lock.  Fix this watcher but adding a
loop.

Fixes the dead lock in containers#16076 surfacing in a timeout.  The underlying
issue persists though.  Also use a timer in the select statement to
prevent the goroutine from running unnecessarily long

[NO NEW TESTS NEEDED]

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
    @vrothberg
    vrothberg committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    c4ebe9e View commit details
    Browse the repository at this point in the history