Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI:DOCS] kube refinements #16270

Merged
merged 2 commits into from
Oct 24, 2022
Merged

[CI:DOCS] kube refinements #16270

merged 2 commits into from
Oct 24, 2022

Conversation

vrothberg
Copy link
Member

  • docs: kube play: mention restart policy
  • docs: generate systemd: point to kube template
Mention in the docs that "always" is the default restart policy for containers created via `kube play`.

@vrothberg
docs: kube play: mention restart policy
c1de4d3 
Mention the default restart policy in the `kube play` docs.

Fixes: containers#16252
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@vrothberg
docs: generate systemd: point to kube template
622638b 
Point to the kube template in the notes of `--new`.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@rhatdan
Copy link
Member

rhatdan commented Oct 24, 2022

LGTM
@containers/podman-maintainers PTAL

Luap99
Luap99 reviewed Oct 24, 2022
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 283ecd4 into containers:main Oct 24, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees

@Luap99 Luap99

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vrothberg @rhatdan @Luap99 @openshift-merge-robot