Fix system df issues with -f and -v
#16234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakecorrenti
force-pushed
the
system-df-verbose-format-usability
branch
from
7da7d90
to
6c0ca79
Compare
|
I think something got screwed up when I had to fix some validate issues. Will figure out how to fix that. |
|
Could you update the man page. |
edsantiago
reviewed
Oct 20, 2022
edsantiago
reviewed
Oct 20, 2022
Fixed the issue of `--format` and `--verbose` flags being allowed in
combination with one another.
Implemented functionality for `--format json` or `--format '{{ json }}' `.
Implemented command-completion help for `--format`.
Fixes: containers#16204
Signed-off-by: Jake Correnti <jcorrenti13@gmail.com>
jakecorrenti
force-pushed
the
system-df-verbose-format-usability
branch
from
6c0ca79
to
e5032a8
Compare
|
looks like this is affected by #16076 |
|
Flakes finally green after multiple restarts. Tests LGTM. @containers/podman-maintainers PTAL. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakecorrenti, vrothberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Nice work! |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue of
--formatand--verboseflags being allowed in combination with one another.Implemented functionality for
--format jsonor--format '{{ json }}'.Implemented command-completion help for
--format.Fixes: #16204
Signed-off-by: Jake Correnti jcorrenti13@gmail.com
Does this PR introduce a user-facing change?