podman pod logs -l no longer panics
#15846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Sep 18, 2022
jakecorrenti
force-pushed
the
pod-logs-latest
branch
2 times, most recently
from
408d30c
to
8c6372f
Compare
|
LGTM |
mheon
reviewed
Sep 19, 2022
Luap99
reviewed
Sep 19, 2022
jakecorrenti
force-pushed
the
pod-logs-latest
branch
from
8c6372f
to
3e33ca1
Compare
rhatdan
reviewed
Sep 27, 2022
rhatdan
reviewed
Sep 27, 2022
jakecorrenti
force-pushed
the
pod-logs-latest
branch
2 times, most recently
from
a70a588
to
0c9ae27
Compare
rhatdan
reviewed
Sep 29, 2022
rhatdan
reviewed
Sep 29, 2022
Fixed issue where executing the command `podman pod logs -l` would panic because it was indexing into an empty arguments array. Signed-off-by: Jake Correnti <jcorrenti13@gmail.com>
jakecorrenti
force-pushed
the
pod-logs-latest
branch
from
0c9ae27
to
6f821f0
Compare
|
/lgtm |
openshift-ci
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakecorrenti, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where executing the command
podman pod logs -lwould panic because it was indexing into an empty arguments array.Fixes: #15556
Signed-off-by: Jake Correnti jcorrenti13@gmail.com
Does this PR introduce a user-facing change?