Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman container clone env patch #15839

Merged
merged 1 commit into from
Sep 17, 2022
Merged

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented Sep 16, 2022

podman container clone was failing when env variables had multiple = in them. Switch split to splitn

resolves #15836

Signed-off-by: Charlie Doern cdoern@redhat.com

Does this PR introduce a user-facing change?

users can specify env variables properly in container clone

podman container clone was failing when env variables had multiple `=` in them.
Switch split to splitn

resolves containers#15836

Signed-off-by: Charlie Doern <cdoern@redhat.com>
@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None release-note and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Sep 16, 2022
@mheon
Copy link
Member

mheon commented Sep 16, 2022

LGTM

@mheon
Copy link
Member

mheon commented Sep 16, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2022
@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4e14fa0 into containers:main Sep 17, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix in #15242 gets confused by environment variables containing '='
4 participants