System tests: cleanup in --format test

[edsantiago]

Followup to #15673 (--format with newlines). I cobbled up a test
for it, but I was sloppy, so the test had issues that I kept
having to band-aid. This is a cleaner way to handle podman-machine.

...and, another unexpected surprise with podman stats. It
fails under rootless cgroupsv1. We can't sweep it under the
rug via skip_if_ubuntu because tests will then fail on RHEL8.
So, add a similar mechanism for testing podman stats.

...plus a non-surprise, the 'search' test flakes. Try minimizing
that by searching only $IMAGE. If quay.io is down, other tests
will certainly fail.

Signed-off-by: Ed Santiago santiago@redhat.com

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [edsantiago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

LGTM

[edsantiago]

/hold

The search test is flaking. I was afraid of that, because search means network which means flakes. Is there any way to call podman search --format without actually trying to ping a registry?

[Luap99]

The search test is flaking. I was afraid of that, because search means network which means flakes. Is there any way to call podman search --format without actually trying to ping a registry?

No the code has to search before it can display the results. Maybe use a local registry?

[edsantiago]

Went with search $IMAGE, which should (I assume) hit only quay.io, and if quay.io is broken, then all tests will fail anyway.

[rhatdan]

/lgtm

[rhatdan]

/hold cancel