Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix swagger documentation #15712

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

sstosh
Copy link
Contributor

@sstosh sstosh commented Sep 9, 2022

  • ContainerKillLibpod "signal" query default is SIGKILL.
  • ContainerStopLibpod "all" query doesn't exist.

Signed-off-by: Toshiki Sonoda sonoda.toshiki@fujitsu.com

Does this PR introduce a user-facing change?

None

* ContainerKillLibpod "signal" query default is SIGKILL.
* ContainerStopLibpod "all" query doesn't exist.

[NO NEW TESTS NEEDED]

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
@sstosh
Copy link
Contributor Author

sstosh commented Sep 9, 2022

From the following logs, I thought that podman stop "all" query doesn't exist.
I'm sorry if I'm not correct.

podman-remote stop --all
# podman start --all
09f1a7be6a125418ad891b06ab7fd3b010739f8f70fc1e7a2e8a09c1f5fc2e4d
bd6be76945084b38d89c2af1aa4c82d85cbdfe4002b004699f09b3d4bda189b0
de26678d503cd8b9ad3ca1c1a7f2782a40c37b2f174f72139da9f3147f664155

# podman-remote --log-level debug stop --all
INFO[0000] podman-remote filtering at log level debug
DEBU[0000] Called stop.PersistentPreRunE(podman-remote --log-level debug stop --all)
DEBU[0000] DoRequest Method: GET URI: http://d/v4.3.0/libpod/_ping
DEBU[0000] DoRequest Method: GET URI: http://d/v4.3.0/libpod/containers/json
DEBU[0000] DoRequest Method: POST URI: http://d/v4.3.0/libpod/containers/de26678d503cd8b9ad3ca1c1a7f2782a40c37b2f174f72139da9f3147f664155/stop
DEBU[0000] DoRequest Method: POST URI: http://d/v4.3.0/libpod/containers/bd6be76945084b38d89c2af1aa4c82d85cbdfe4002b004699f09b3d4bda189b0/stop
DEBU[0000] DoRequest Method: POST URI: http://d/v4.3.0/libpod/containers/09f1a7be6a125418ad891b06ab7fd3b010739f8f70fc1e7a2e8a09c1f5fc2e4d/stop
de26678d503cd8b9ad3ca1c1a7f2782a40c37b2f174f72139da9f3147f664155
bd6be76945084b38d89c2af1aa4c82d85cbdfe4002b004699f09b3d4bda189b0
09f1a7be6a125418ad891b06ab7fd3b010739f8f70fc1e7a2e8a09c1f5fc2e4d
DEBU[0000] Called stop.PersistentPostRunE(podman-remote --log-level debug stop --all)

@rhatdan
Copy link
Member

rhatdan commented Sep 9, 2022

stop --all is handled on the client side not on the server.
LGTM
/approve
@containers/podman-desktop-maintainers PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 9, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, sstosh, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b0b3643 into containers:main Sep 9, 2022
@sstosh sstosh deleted the fix-swagger branch September 9, 2022 13:05
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants