e2e: Add run --memory-swap test #15447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is not e2e/system test of --memory-swap option. Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
vrothberg
reviewed
Aug 24, 2022
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
lgtm
edsantiago
approved these changes
Aug 24, 2022
| ) | ||
|
|
||
| if CGROUPSV2 { | ||
| session = podmanTest.Podman([]string{"run", "--memory=20m", "--memory-swap=30M", "--net=none", ALPINE, "sh", "-c", "cat /sys/fs/cgroup/$(sed -e 's|0::||' < /proc/self/cgroup)/memory.swap.max"}) |
There was a problem hiding this comment.
Just curious: is the sed thing really necessary? Are there any circumstances in which it won't just be /?
|
|
||
| if CGROUPSV2 { | ||
| session = podmanTest.Podman([]string{"run", "--memory=20m", "--memory-swap=30M", "--net=none", ALPINE, "sh", "-c", "cat /sys/fs/cgroup/$(sed -e 's|0::||' < /proc/self/cgroup)/memory.swap.max"}) | ||
| expect = "10485760" |
There was a problem hiding this comment.
People not intimately familiar with cgroups v2 might appreciate a comment like // 30m - 20m as a reminder that cgroups v2 stores the delta, not the total. But this is not a showstopper. LGTM.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, giuseppe, sstosh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is not e2e/system test of --memory-swap option.
Signed-off-by: Toshiki Sonoda sonoda.toshiki@fujitsu.com
Does this PR introduce a user-facing change?