Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix "podman search format json" #14152

Merged
merged 1 commit into from
May 9, 2022

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented May 8, 2022

the alpine image used previously returns a description that contains
'...':

$ podman search --format json alpine | fgrep ...",
"Description": "alpine 3.7 with bash, perl, gzip, wget...",

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

Does this PR introduce a user-facing change?

None

the alpine image used previously returns a description that contains
'...':

$ podman search --format json alpine | fgrep ...\"\,
        "Description": "alpine 3.7 with bash, perl, gzip, wget...",

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2022
@rhatdan
Copy link
Member

rhatdan commented May 8, 2022

Was this breaking something?

@rhatdan
Copy link
Member

rhatdan commented May 8, 2022

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on what is breaking?

@giuseppe
Copy link
Member Author

giuseppe commented May 9, 2022

tests are failing in the other open PRs.

We are checking that the returned description doesn't end with ..., but there is such description now in the alpine image:

$ wget -qO- "https://index.docker.io/v1/search?n=25&q=alpine" | jq '.results[].description' | grep \\.\\.\\.\"$
"alpine 3.7 with bash, perl, gzip, wget..."

@vrothberg
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 2dcf306 into containers:main May 9, 2022
@edsantiago
Copy link
Member

/cherry-pick v4.1

@openshift-cherrypick-robot
Copy link
Collaborator

@edsantiago: only containers org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick v4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rhatdan
Copy link
Member

rhatdan commented May 9, 2022

/cherry-pick v4.1

@openshift-cherrypick-robot
Copy link
Collaborator

@rhatdan: new pull request created: #14164

In response to this:

/cherry-pick v4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants