Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play kube log tag handling #14121

Merged
merged 1 commit into from
May 9, 2022
Merged

play kube log tag handling #14121

merged 1 commit into from
May 9, 2022

Conversation

cdoern
Copy link
Contributor

@cdoern cdoern commented May 5, 2022 •
edited
Loading

currently tags cause a panic due to an uninitialized map. Initialize the map
and add parsing to make sure we are only tagging with journald

resolves #13356

Signed-off-by: cdoern cbdoer23@g.holycross.edu

flouthoc
flouthoc reviewed May 5, 2022
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments above otherwise LGTM

@mheon
Copy link
Member

mheon commented May 5, 2022

LGTM once comments are addressed

@Luap99
Copy link
Member

Luap99 commented May 5, 2022

Also remove the test/e2e/hello.tar file from the commit

@TomSweeneyRedHat
Copy link
Member

LGTM
but you're fighting some whitespace issues.

play kube log tag handling
b58e7e7 
currently tags cause a panic due to an uninitialized map. Initialize the map
and add parsing to make sure we are only tagging with journald

resolves containers#13356

Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
vrothberg
vrothberg approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdoern, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit ccb6211 into containers:main May 9, 2022
@mheon
Copy link
Member

mheon commented Jun 9, 2022

/cherry-pick v4.1

@openshift-cherrypick-robot
Copy link
Collaborator

@mheon: new pull request created: #14550

In response to this:

/cherry-pick v4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 9, 2022
Closed
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@flouthoc flouthoc flouthoc left review comments

@Luap99 Luap99 Luap99 left review comments

@vrothberg vrothberg vrothberg approved these changes

Assignees

@vrothberg vrothberg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Play Kube --log-opt causing panic
8 participants
@cdoern @mheon @Luap99 @TomSweeneyRedHat @openshift-cherrypick-robot @flouthoc @vrothberg @openshift-merge-robot