Add CreatedSince & CreatedAt format fields to podman image history #14034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
edsantiago
reviewed
Apr 27, 2022
test/system/010-images.bats
Outdated
| @@ -312,4 +312,19 @@ Deleted: $pauseID" | |||
| is "$output" "" | |||
| } | |||
|
|
|||
| @test "podman image history" { | |||
There was a problem hiding this comment.
There's already a 110-history.bats, I wonder if some of this could be piggybacked there?
edsantiago
requested changes
Apr 27, 2022
Comment on lines
26
to
30
| | .CreatedAt | Time when the image layer was created | | ||
| | .CreatedBy | Command used to create the layer | | ||
| | .CreatedSince | Elapsed time since the image layer was created | | ||
| | .Size | Size of layer on disk | | ||
| | .Comment | Comment for the layer | |
There was a problem hiding this comment.
Bars on right-hand side need to be aligned
test/system/010-images.bats
Outdated
| run_podman image history --format '{{.CreatedAt}}' $IMAGE | ||
| line="$lines[0]" | ||
| run cut -f1 -d'.' <<< "$line" | ||
| assert "${output}" == "$imageAt" "History image list should match .CreatedAt" |
There was a problem hiding this comment.
This fails on my laptop:
#| FAIL: History image list should match .CreatedAt
#| expected: '2021-06-10 18:55:43 +0000 UTC'
#| actual: '2021-06-10 18:55:43'
There was a problem hiding this comment.
Worked on my system, once. Will try again.
rhatdan
force-pushed
the
history
branch
2 times, most recently
from
54ba8ce
to
2a27e0d
Compare
edsantiago
approved these changes
Apr 27, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
edsantiago
reviewed
Apr 27, 2022
test/system/110-history.bats
Outdated
Comment on lines
59
to
67
| run_podman image list --format '{{.CreatedSince}}' $IMAGE | ||
| imageSince="$output" | ||
| run_podman image list --format '{{.CreatedAt}}' $IMAGE | ||
| imageAt=$output | ||
| run_podman image history $IMAGE | ||
| run_podman image history --format '{{.CreatedSince}}' $IMAGE | ||
| is "${lines[0]}" "$imageSince" "History image list should match .CreatedSince" | ||
| run_podman image history --format '{{.CreatedAt}}' $IMAGE | ||
| assert "${lines[0]}" == "$imageAt" "History image list should match .CreatedAt" |
There was a problem hiding this comment.
LGTM but should you need to re-push for any reason, a small suggestion that reduces the number of podman calls (hence reduces CI time) and also runs sanity checks on the time values
@test "podman image history Created" {
# Values from image LIST
run_podman image list --format '{{.CreatedSince}}--{{.CreatedAt}}' $IMAGE
from_imagelist="$output"
assert "$from_imagelist" =~ "^[0-9].* ago--[0-9]+-[0-9]+-[0-9]+ [0-9:]+ " \
"CreatedSince and CreatedAt look reasonable"
# Values from image HISTORY
run_podman image history --format '{{.CreatedSince}}--{{.CreatedAt}}' $IMAGE
assert "${lines[0]}" == "$from_imagelist" \
"CreatedSince and CreatedAt from image history should == image list"
}
Fixes: containers#14012 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
LGTM |
|
/lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14012
Signed-off-by: Daniel J Walsh dwalsh@redhat.com