Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readConmonPipeData: try to improve error #13637

Merged
merged 1 commit into from
Mar 24, 2022

Commits on Mar 24, 2022

  1. readConmonPipeData: try to improve error

    Issue containers#10927 reports `container create failed (no logs from conmon): EOF`
    errors. Since we do not know the root cause it would be helpful to try
    to get as much info as possible out of the error.
    (buffer).ReadBytes() will return the bytes read even when an error
    occurs. So when we get an EOF we could still have some valuable
    information in the buffer. Lets try to unmarshal them and if this fails
    we add the bytes to the error message.
    
    This does not fix the issue but it might help us getting a better error.
    
    [NO NEW TESTS NEEDED]
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Mar 24, 2022
    Configuration menu
    Copy the full SHA
    7ae52e8 View commit details
    Browse the repository at this point in the history