-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v4.0-rhel backport] bump to race-free c/image
and c/storage
along with test to verify concurrent/parallel
builds
#13623
[v4.0-rhel backport] bump to race-free c/image
and c/storage
along with test to verify concurrent/parallel
builds
#13623
Conversation
Bump c/storage to v1.38.3 so podman could use new `race-free` `AddNames` and `RemoveNames` api Signed-off-by: Aditya R <arajan@redhat.com>
Bump c/image to upstream v5.19.2 so podman could use new race-free code. Signed-off-by: Aditya R <arajan@redhat.com>
Invoking parallel/concurrent builds from podman race against each other following behviour was fixed in containers/storage#1153 and containers/image#1480 Test verifies if following bug is fixed in new race-free API or not. Read more about this issue, see bz 2055487 for more details. Test manually backported from: containers@63f92d0 Signed-off-by: Aditya R <arajan@redhat.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mheon @TomSweeneyRedHat fixes for |
Won't we need Buildah bumped too? Otherwise LGTM. |
And we'll need this in the 4.0 branch. |
At least partially addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2066519 RHEL 8.6 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2055487 |
@TomSweeneyRedHat Buildah vendor is not necessary needed to fix this in podman ( i.e for But if we are also planning to release a new back-ported binary of buildah then |
Just created a PR for that in |
Exceptions approved: RHEL 9.0 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2066519 RHEL 8.6 BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2055487 |
/lgtm |
Commits explained in bullet points.
c/storage
tov1.38.3
released here: [v1.38, backport] store: add independentAddNames
andRemoveNames
for images,layers,containers storage#1174c/image
tov5.19.2
released here: [v5.19, backport] storage: use race-freeAddNames
instead ofSetNames
image#1503New Names API in
c/storage
andc/image
ensures that Name modification operations arerace-free
.For reference actual upstream PR: containers/image#1480 and containers/storage#1153