Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman system df: fix percent calculation #13575

Merged
merged 1 commit into from
Mar 21, 2022

Commits on Mar 21, 2022

  1. podman system df: fix percent calculation

    The calculate the percentage we need floating point numbers. The current
    code however casted the result of reclaimable/size to an int first.
    Casting to an int in go will just discard the decimal points, thus the
    result was either 0 or 1 so if multiplied by 100 it would show up as 0%
    or 100%.
    
    To fix this we have to multiply by 100 first before casting the result
    to an int. Also add a check for div by zero which results in NaN and use
    math.Round() to correctly round a number.
    
    Ref containers#13516
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Mar 21, 2022
    Configuration menu
    Copy the full SHA
    e3cc071 View commit details
    Browse the repository at this point in the history