-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify v2 API testing for podman vs docker clients #13374
Clarify v2 API testing for podman vs docker clients #13374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on Ghost Rider, while the tests could be better laid out -- python/docker tests use DockerClient NOT PodmanClient. Given discussions in the group we may want to extend these tests not remove them.
That's what I half-suspected, thanks for clarifying. Okay, let me re-push a new version of this that tries to make the situation more clear. Along those lines, is there something that can be done in the actual tests to show which client is being used? I'm assuming our setup is correct...but I'd prefer not to assume if I can be told for sure. |
bd4790a
to
6b5c173
Compare
ddfcf69
to
cff45fe
Compare
Fixes: containers#13273 Signed-off-by: Chris Evich <cevich@redhat.com>
cff45fe
to
dbf34bf
Compare
Okay there, that should be much better. Now there's always a message or warning visible no matter if the python-traceback occupies an 10-screenfulls or not 😄 |
K, this should be good-to-go. |
LGTM |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #13273