Allow API to specify size and inode quota #11991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Looks like you have a vendor problem @rhatdan |
Luap99
reviewed
Oct 18, 2021
libpod/container_config.go
Outdated
| @@ -153,6 +153,8 @@ type ContainerRootFSConfig struct { | |||
| Secrets []*ContainerSecret `json:"secrets,omitempty"` | |||
| // SecretPath is the secrets location in storage | |||
| SecretsPath string `json:"secretsPath"` | |||
| // StorageOpts to be used when creating rootfs | |||
| StorageOpts []string `json:"storageOpts"` | |||
There was a problem hiding this comment.
I think this should be a map[string]string given the c/storage accepts this, to avoid converting the array every time.
rhatdan
force-pushed
the
size
branch
2 times, most recently
from
0690213
to
1af8243
Compare
Fixes: containers#11016 [NO NEW TESTS NEEDED] We have no easy way to tests this in CI/CD systems. Requires quota to be setup on directories to work. Fixes: containers#11016 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@Luap99 PTAL |
|
LGTM |
This was referenced Jan 7, 2022
riyad
added a commit
to riyad/podman
that referenced
this pull request
Jan 7, 2022
[NO NEW TESTS NEEDED] see containers#11991 Signed-off-by: Riyad Preukschas <riyad@informatik.uni-bremen.de>
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11016
[NO NEW TESTS NEEDED] We have no easy way to tests this in
CI/CD systems. Requires quota to be setup on directories to work.
Fixes: #11016
Signed-off-by: Daniel J Walsh dwalsh@redhat.com
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: