If CONTAINER_HOST env variable is set default podman --remote=true #11978
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Should we do the same for |
|
Yes and that does not seem to be documented anywhere. |
docs/source/markdown/podman.1.md
Outdated
| @@ -95,6 +95,7 @@ Path to the command binary to use for setting up a network. It is currently onl | |||
| #### **--remote**, **-r** | |||
| Access Podman service will be remote | |||
| Remote connections use local containers.conf for default. | |||
| When CONTAINER_HOST environment variable is set default to true. | |||
There was a problem hiding this comment.
I'm not parsing much of this.
| When CONTAINER_HOST environment variable is set default to true. | |
| When true, access to the Podman service will be remote. When the CONTAINER_HOST environment variable is set, the remote option defaults to true. Remote connections use the local containers.conf file by default. |
Is remote false by default or set from containers.conf? That should be added.
Users enabling CONTAINER_HOST==PATH is indicating to podman they intend to use remote functionality. Fixes: containers#11196 Update man pages to document all of the environment variables. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@containers/podman-maintainers PTAL |
|
/lgtm |
|
I do not think this works. Remote must be parsed before any cli commands are defined. The code handles this in a special way here: podman/cmd/podman/registry/remote.go Line 20 in 171f7b8 This is because the cli changes depending if we are remote or not, so when cobra parsed the --remote flag it is already to late. |
Current code does not check early enough. Follow up to containers#11978 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Current code does not check early enough. Follow up to containers#11978 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Current code does not check early enough. Follow up to containers#11978 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
github-actions
bot
added
the
locked - please file new issue/PR
Users enabling CONTAINER_HOST==PATH is indicating to podman they intend
to use remote functionality.
Fixes: #11196
Signed-off-by: Daniel J Walsh dwalsh@redhat.com
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer: