Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear up fragments of the old api #116

Closed
wants to merge 1 commit into from

Conversation

umohnani8
Copy link
Member

As everything is being moved over to the new container api
removing files that depended on the old api

Signed-off-by: umohnani8 umohnani@redhat.com

@umohnani8
Copy link
Member Author

Waiting on #106 and #113

@TomSweeneyRedHat
Copy link
Member

@umohnani8 looks like you need to rebase.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably 88121e0) made this pull request unmergeable. Please resolve the merge conflicts.

@rhatdan
Copy link
Member

rhatdan commented Dec 13, 2017

@umohnani8 Needs a rebase.

@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably #106) made this pull request unmergeable. Please resolve the merge conflicts.

@umohnani8 umohnani8 force-pushed the clear_libkpod branch 3 times, most recently from d01e07d to 7efad6c Compare December 13, 2017 21:08
@rh-atomic-bot
Copy link
Collaborator

☔ The latest upstream changes (presumably 9cc0c8a) made this pull request unmergeable. Please resolve the merge conflicts.

As everything is being moved over to the new container api
removing files that depended on the old api

Signed-off-by: umohnani8 <umohnani@redhat.com>
@umohnani8 umohnani8 changed the title [WIP] Clear up fragments of the old api Clear up fragments of the old api Dec 13, 2017
@umohnani8
Copy link
Member Author

Ready to merge once tests are green

@mheon
Copy link
Member

mheon commented Dec 13, 2017

LGTM
@rhatdan PTAL

Copy link
Member

@TomSweeneyRedHat TomSweeneyRedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Dec 14, 2017

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 7262d0f has been approved by rhatdan

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 7262d0f with merge 05f4dd9...

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr
Approved by: rhatdan
Pushing 05f4dd9 to master...

@umohnani8 umohnani8 deleted the clear_libkpod branch March 16, 2018 14:41
baude pushed a commit to baude/podman that referenced this pull request Aug 31, 2019
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants