Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

podman-remote build: outputs duplicate image ID #8332

Closed
edsantiago opened this issue Nov 13, 2020 · 1 comment · Fixed by #8333
Closed

podman-remote build: outputs duplicate image ID #8332

edsantiago opened this issue Nov 13, 2020 · 1 comment · Fixed by #8333
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

podman-remote is emitting two image IDs upon build:

$ printf "FROM alpine\nRUN true\n" | ./bin/podman-remote build -t foo -
STEP 1: FROM alpine
STEP 2: RUN true
STEP 3: COMMIT foo
Getting image source signatures
Copying blob sha256:ace0eda3e3be35a979cec764a3321b4c7d0b9e4bb3094d20d3ff6782961a8d54
Copying blob sha256:9748d086fc05759a0f454343488417ebd1f24ad3ed2da3aae7108d1bc5c8b78d
Copying config sha256:b0a454ec5bb8d9a86c00be51e114c7c10a92dea2adeb15a4da156040a4ff224b
Writing manifest to image destination
Storing signatures
--> b0a454ec5bb
b0a454ec5bb8d9a86c00be51e114c7c10a92dea2adeb15a4da156040a4ff224b
b0a454ec5bb8d9a86c00be51e114c7c10a92dea2adeb15a4da156040a4ff224b% <--- the '%' means 'no trailing newline'

Expected: just one instance of the SHA. Compare to podman non-remote:

STEP 1: FROM alpine
STEP 2: RUN true
--> Using cache c3ba237ce4f93d78efa4ffcc16073ba736772c5b86158f83c4e6954243d3d118
STEP 3: COMMIT foo
--> c3ba237ce4f
c3ba237ce4f93d78efa4ffcc16073ba736772c5b86158f83c4e6954243d3d118

Behavior present in master, also podman-2.1.1-7.fc32
@edsantiago edsantiago added kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Nov 13, 2020
@edsantiago edsantiago mentioned this issue Nov 13, 2020
Merged
rhatdan added a commit to rhatdan/podman that referenced this issue Nov 13, 2020
@rhatdan
Podman-remote build is getting ID twice
dd75e92 
This PR eliminates the second sending of the image id to the
podman-remote client.

Fixes: containers#8332

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan mentioned this issue Nov 13, 2020
Merged
@edsantiago
Copy link
Member Author

I think this got closed by accident or typo? The bot-linked PR has nothing to do with this; the PR that fixes this bug is #8333, which is still hiccuping in CI. I'm reopening this.

@edsantiago edsantiago reopened this Nov 14, 2020
rhatdan added a commit to rhatdan/podman that referenced this issue Nov 14, 2020
@rhatdan
Podman-remote build is getting ID twice
b5e15f1 
This PR eliminates the second sending of the image id to the
podman-remote client.

Fixes: containers#8332

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
vrothberg pushed a commit to vrothberg/libpod that referenced this issue Nov 24, 2020
@Luap99 @vrothberg
Add podman build --net alias for --network
ab47295 
Fixes containers#8332

Signed-off-by: Paul Holzinger <paul.holzinger@web.de>
vrothberg pushed a commit to vrothberg/libpod that referenced this issue Nov 24, 2020
@rhatdan @vrothberg
Podman-remote build is getting ID twice
2fd41e8 
This PR eliminates the second sending of the image id to the
podman-remote client.

Fixes: containers#8332

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Podman-remote build is getting ID twice rhatdan/podman
1 participant
@edsantiago