Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: podman-remote exec: no stderr #8281

Closed
edsantiago opened this issue Nov 9, 2020 · 10 comments · Fixed by #9105
Closed

regression: podman-remote exec: no stderr #8281

edsantiago opened this issue Nov 9, 2020 · 10 comments · Fixed by #9105
Assignees
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

This is an exact resurrection of #4096. It was working in v2.0, broken in v2.1. It was not caught because the CI test was disabled due to flake #7241 .

In window 1:

$ ./bin/podman system service --timeout=0

Window 2:

$ ./bin/podman-remote run -d --name foo alpine sleep 60
282efa747bd064007e594362a4697567226f8ebdb0b288e98f231ebdd464a7d7
$ ./bin/podman-remote exec foo /no/such/command
$ ./bin/podman-remote exec foo /etc

Note the missing output: there should be errors from each one. The errors actually appear in window 1 (server):

ERRO[0031] error attaching to container282efa747bd064007e594362a4697567226f8ebdb0b288e98f231ebdd464a7d7 exec session 018f23462f0c1d704a175f825c327dcce1ce3dba37bcfcbf8db236600f98ddc9: executable file `/no/such/command` not found in $PATH: No such file or directory: OCI not found
ERRO[0034] error attaching to container 282efa747bd064007e594362a4697567226f8ebdb0b288e98f231ebdd464a7d7 exec session 3b3852b4b3b6eca4e321385be65afc0fd52b061a37978f8ef029a367a7d7fcbc: open executable: Operation not permitted: OCI permission denied
@edsantiago edsantiago added kind/bug Categorizes issue or PR as related to a bug. remote Problem is in podman-remote labels Nov 9, 2020
@edsantiago
Copy link
Member Author

Whoever fixes this: please include the following patch in your PR:

diff --git a/test/system/075-exec.bats b/test/system/075-exec.bats
index edd7dedc4..19b4c1afc 100644
--- a/test/system/075-exec.bats
+++ b/test/system/075-exec.bats
@@ -6,8 +6,6 @@
 load helpers

 @test "podman exec - basic test" {
-    skip_if_remote "FIXME: pending #7241"
-
     rand_filename=$(random_string 20)
     rand_content=$(random_string 50)

@rhatdan
Copy link
Member

rhatdan commented Nov 10, 2020

@mheon this seems like something you should be able to understand/fix?

@zhangguanzhang
Copy link
Collaborator

2ea9dac
this pr change

@zhangguanzhang
Copy link
Collaborator

@mheon

@mheon mheon added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Nov 12, 2020
@github-actions
Copy link

A friendly reminder that this issue had no activity for 30 days.

@rhatdan
Copy link
Member

rhatdan commented Dec 14, 2020

@mheon This seems pretty critical, I have just reproduced. Any idea where this is happening?

@mheon
Copy link
Member

mheon commented Dec 14, 2020

Honestly, no. Too many different errors happening at different places and times in the exec code.

@edsantiago
Copy link
Member Author

ping, issue is still present and blocking #8871, which in turn prevents us from checking if #7241 (podman-remote hang) is truly fixed.

@vrothberg
Copy link
Member

I have some free cycles this afternoon and will have a look.

@vrothberg
Copy link
Member

Taking another stab.

vrothberg added a commit to vrothberg/libpod that referenced this issue Jan 26, 2021
Fixes: containers#8281
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jan 26, 2021
Fixes: containers#8281
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jan 27, 2021
Make sure to write error from conmon on the hijacked http connection.
This fixes issues where errors were not reported on the client side,
for instance, when specified command was not found on the container.

To future generations: I am sorry.  The code is complex, and there are
many interdependencies among the concurrent goroutines.  I added more
complexity on top but I don't have a good idea of how to reduce
complexity in the available time.

Fixes: containers#8281
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
mheon pushed a commit to mheon/libpod that referenced this issue Jan 29, 2021
Make sure to write error from conmon on the hijacked http connection.
This fixes issues where errors were not reported on the client side,
for instance, when specified command was not found on the container.

To future generations: I am sorry.  The code is complex, and there are
many interdependencies among the concurrent goroutines.  I added more
complexity on top but I don't have a good idea of how to reduce
complexity in the available time.

Fixes: containers#8281
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants