Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing --remove-signatures in podman-remote push #14558

Closed
cfergeau opened this issue Jun 10, 2022 · 2 comments
Closed

Missing --remove-signatures in podman-remote push #14558

cfergeau opened this issue Jun 10, 2022 · 2 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. macos MacOS (OSX) related remote Problem is in podman-remote

Comments

@cfergeau
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

podman-remote push does not support --remove-signatures

Steps to reproduce the issue:

These commands are run on macOS, so this is using podman-remote

  1. podman pull registry.access.redhat.com/ubi8

  2. podman push registry.access.redhat.com/ubi8 quay.io/teuf/ubi8

Describe the results you received:

This fails with Error: Copying this image would require changing layer representation, which we cannot do: "Would invalidate signatures"

Describe the results you expected:

On linux, I can use podman push --remove-signatures to avoid this (maybe there are other ways to deal with it, but I'm not aware of them). On macOS, I don't have such an option.

Output of podman version:

Client:       Podman Engine
Version:      4.1.0
API Version:  4.1.0
Go Version:   go1.18.1
Built:        Thu May  5 22:07:47 2022
OS/Arch:      darwin/amd64

Server:       Podman Engine
Version:      4.1.0
API Version:  4.1.0
Go Version:   go1.18
Built:        Fri May  6 18:15:54 2022
OS/Arch:      linux/amd64

Output of podman info --debug:

host:
  arch: amd64
  buildahVersion: 1.26.1
  cgroupControllers:
  - cpu
  - io
  - memory
  - pids
  cgroupManager: systemd
  cgroupVersion: v2
  conmon:
    package: conmon-2.1.0-2.fc36.x86_64
    path: /usr/bin/conmon
    version: 'conmon version 2.1.0, commit: '
  cpuUtilization:
    idlePercent: 99.81
    systemPercent: 0.16
    userPercent: 0.03
  cpus: 1
  distribution:
    distribution: fedora
    variant: coreos
    version: "36"
  eventLogger: journald
  hostname: localhost.localdomain
  idMappings:
    gidmap:
    - container_id: 0
      host_id: 1000
      size: 1
    - container_id: 1
      host_id: 100000
      size: 1000000
    uidmap:
    - container_id: 0
      host_id: 501
      size: 1
    - container_id: 1
      host_id: 100000
      size: 1000000
  kernel: 5.17.5-300.fc36.x86_64
  linkmode: dynamic
  logDriver: journald
  memFree: 889581568
  memTotal: 2066817024
  networkBackend: netavark
  ociRuntime:
    name: crun
    package: crun-1.4.4-1.fc36.x86_64
    path: /usr/bin/crun
    version: |-
      crun version 1.4.4
      commit: 6521fcc5806f20f6187eb933f9f45130c86da230
      spec: 1.0.0
      +SYSTEMD +SELINUX +APPARMOR +CAP +SECCOMP +EBPF +CRIU +YAJL
  os: linux
  remoteSocket:
    exists: true
    path: /run/user/501/podman/podman.sock
  security:
    apparmorEnabled: false
    capabilities: CAP_CHOWN,CAP_DAC_OVERRIDE,CAP_FOWNER,CAP_FSETID,CAP_KILL,CAP_NET_BIND_SERVICE,CAP_SETFCAP,CAP_SETGID,CAP_SETPCAP,CAP_SETUID,CAP_SYS_CHROOT
    rootless: true
    seccompEnabled: true
    seccompProfilePath: /usr/share/containers/seccomp.json
    selinuxEnabled: true
  serviceIsRemote: true
  slirp4netns:
    executable: /usr/bin/slirp4netns
    package: slirp4netns-1.2.0-0.2.beta.0.fc36.x86_64
    version: |-
      slirp4netns version 1.2.0-beta.0
      commit: 477db14a24ff1a3de3a705e51ca2c4c1fe3dda64
      libslirp: 4.6.1
      SLIRP_CONFIG_VERSION_MAX: 3
      libseccomp: 2.5.3
  swapFree: 0
  swapTotal: 0
  uptime: 25h 42m 51.49s (Approximately 1.04 days)
plugins:
  log:
  - k8s-file
  - none
  - passthrough
  - journald
  network:
  - bridge
  - macvlan
  volume:
  - local
registries:
  search:
  - docker.io
store:
  configFile: /var/home/core/.config/containers/storage.conf
  containerStore:
    number: 3
    paused: 0
    running: 1
    stopped: 2
  graphDriverName: overlay
  graphOptions: {}
  graphRoot: /var/home/core/.local/share/containers/storage
  graphRootAllocated: 106825756672
  graphRootUsed: 2672336896
  graphStatus:
    Backing Filesystem: xfs
    Native Overlay Diff: "true"
    Supports d_type: "true"
    Using metacopy: "false"
  imageCopyTmpDir: /var/tmp
  imageStore:
    number: 2
  runRoot: /run/user/501/containers
  volumePath: /var/home/core/.local/share/containers/storage/volumes
version:
  APIVersion: 4.1.0
  Built: 1651853754
  BuiltTime: Fri May  6 18:15:54 2022
  GitCommit: ""
  GoVersion: go1.18
  Os: linux
  OsArch: linux/amd64
  Version: 4.1.0

Have you tested with the latest version of Podman and have you checked the Podman Troubleshooting Guide? (https://github.com/containers/podman/blob/main/troubleshooting.md)

I tested latest version, I also looked at a git build where I could not find the option.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 10, 2022
@github-actions github-actions bot added macos MacOS (OSX) related remote Problem is in podman-remote labels Jun 10, 2022
@rhatdan
Copy link
Member

rhatdan commented Jun 10, 2022

@vrothberg @mtrmac Any idea why this is not supported with --remote?

@rhatdan
Copy link
Member

rhatdan commented Jun 10, 2022

tig blame , blames it on me. I think I read this wrong will open a PR to turn it on.

praveenkumar added a commit to praveenkumar/crc that referenced this issue Jun 20, 2022
This patch uses `oc mirror` command to push image from remote container
registry to openshift internal registry and make it available to
imagestream. Recently user observed if ubi images are pulled using
podman then pushing it to internal registry have signature verification
error (containers/podman#14558) for
mac/windows. This issue is recently fixed on podman remote clients but
still not released so better not to use podman/docker steps just to show
user around internal registry usage.
praveenkumar added a commit to praveenkumar/crc that referenced this issue Jun 20, 2022
This patch uses `oc mirror` command to push image from remote container
registry to openshift internal registry and make it available to
imagestream. Recently user observed if ubi images are pulled using
podman then pushing it to internal registry have signature verification
error (containers/podman#14558) for
mac/windows. This issue is recently fixed on podman remote clients but
still not released so better not to use podman/docker steps just to show
user around internal registry usage.

It will also change apline to ubi8 image.
anjannath pushed a commit to crc-org/crc that referenced this issue Jun 22, 2022
This patch uses `oc mirror` command to push image from remote container
registry to openshift internal registry and make it available to
imagestream. Recently user observed if ubi images are pulled using
podman then pushing it to internal registry have signature verification
error (containers/podman#14558) for
mac/windows. This issue is recently fixed on podman remote clients but
still not released so better not to use podman/docker steps just to show
user around internal registry usage.

It will also change apline to ubi8 image.
gbraad pushed a commit to gbraad-redhat/podman that referenced this issue Jul 13, 2022
I don't see a reason why we don't support --remove-signatures
from remote push, so adding support.

Fixes: containers#14558

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. macos MacOS (OSX) related remote Problem is in podman-remote
Projects
None yet
Development

No branches or pull requests

2 participants