Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout in podman-save multi-image #14468

Closed
edsantiago opened this issue Jun 2, 2022 · 2 comments · Fixed by #14475
Closed

Timeout in podman-save multi-image #14468

edsantiago opened this issue Jun 2, 2022 · 2 comments · Fixed by #14475
Assignees
@vrothberg
Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote

Comments

@edsantiago
Copy link
Member

Seeing this one much more frequently. Seems to be remote only.

# podman-remote [options] save -o /tmp/podman_test2110863551/temp.tar --multi-image-archive 215122d241c2 0d9e0c1523d9 08c1631d50a3 ecea49d99daa b85bdf5fbb1c 5e9e9275e4d6 8835e6aeca99 f0b02e9d092d 80d28bedfe5d 10b45af23ff3 961769676411 c1103abb47d6
Copying blob sha256:a7e6caf12d36232c05ce95d911fa5dace3f81d2f0e39556182015d258c881b64
...
? Failure [92.921 seconds]
Podman save
/var/tmp/go/src/github.com[/containers/podman/test/e2e/save_test.go:18](https://github.com/containers/podman/blob/3fa09e9dba1710f97dbe0f2062685d06fb2fb243/test/e2e/save_test.go#L18)
  podman save --multi-image-archive (untagged images) [It]
  /var/tmp/go/src/github.com[/containers/podman/test/e2e/save_test.go:228](https://github.com/containers/podman/blob/3fa09e9dba1710f97dbe0f2062685d06fb2fb243/test/e2e/save_test.go#L228)
         
  Timed out after 90.000s.
  Expected process to exit.  It did not.

Podman save [It] podman save --multi-image-archive (untagged images)

I've added the remote label but have noticed that some github bot autodeletes it every time I create an issue. Anyone know what that's about? (Watch it not happen on this one)
@edsantiago edsantiago added flakes Flakes from Continuous Integration remote Problem is in podman-remote labels Jun 2, 2022
@github-actions github-actions bot removed the remote Problem is in podman-remote label Jun 2, 2022
@edsantiago edsantiago added the remote Problem is in podman-remote label Jun 2, 2022
@vrothberg vrothberg self-assigned this Jun 3, 2022
@vrothberg
Copy link
Member

I'll take a look, thanks for the great reports, @edsantiago.

vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 3, 2022
@vrothberg
test/e2e/save_test.go: fix flake
162acec 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: containers#14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@vrothberg vrothberg mentioned this issue Jun 3, 2022
Merged
@vrothberg
Copy link
Member

-> #14475

vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 3, 2022
@vrothberg
test/e2e/save_test.go: fix flake
a4ea3ca 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: containers#14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 3, 2022
@vrothberg
test/e2e/save_test.go: fix flake
1e9a9b1 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: containers#14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 3, 2022
@vrothberg
image list: do not reformat .CreatedAt
672ff1f 
As shown in containers#14468, the `.CreatedAt` fields for `image list` and of
`image history` can differ by one.  The discussed theory is that the
off-by-one is caused by rounding.

Indeed, the field of `image list` is reformatted.  `image history` is
returning the UNIX time; just as the `.CreatedAt` field should.

I am unable to create a reproducer for the issue but double-checked
what the docker client does: return the UNIX time.

[NO NEW TESTS NEEDED]

Fixes: containers#14456
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 3, 2022
@vrothberg
image list: do not reformat .CreatedAt
a569b9a 
As shown in containers#14468, the `.CreatedAt` fields for `image list` and of
`image history` can differ by one.  The discussed theory is that the
off-by-one is caused by rounding.

Indeed, the field of `image list` is reformatted.  `image history` is
returning the UNIX time; just as the `.CreatedAt` field should.

I am unable to create a reproducer for the issue but double-checked
what the docker client does: return the UNIX time.

[NO NEW TESTS NEEDED]

Fixes: containers#14456
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
vrothberg added a commit to vrothberg/libpod that referenced this issue Jun 3, 2022
@vrothberg
test/e2e/save_test.go: fix flake
2b0cb30 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: containers#14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 14, 2022
@vrothberg @mheon
test/e2e/save_test.go: fix flake
b91a7ec 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: containers#14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 14, 2022
@vrothberg @mheon
test/e2e/save_test.go: fix flake
76adcce 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: containers#14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
karthikelango137 pushed a commit to karthikelango137/podman that referenced this issue Jun 16, 2022
@vrothberg @karthikelango137
test/e2e/save_test.go: fix flake
2a9afff 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: containers#14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
gbraad pushed a commit to gbraad-redhat/podman that referenced this issue Jul 13, 2022
@vrothberg
test/e2e/save_test.go: fix flake
0c33dd7 
Save at most three images and sort them by size.  The test started to
flake as _all_ local images were saved which is not neccessary.

Fixes: containers#14468
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vrothberg vrothberg

Labels
flakes Flakes from Continuous Integration locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. remote Problem is in podman-remote
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test/e2e/save_test.go: fix flake vrothberg/libpod
2 participants
@edsantiago @vrothberg