Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot filter containers for removing status in API #13986

Closed
nivekuil opened this issue Apr 23, 2022 · 0 comments · Fixed by #13988
Closed

Cannot filter containers for removing status in API #13986

nivekuil opened this issue Apr 23, 2022 · 0 comments · Fixed by #13988
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@nivekuil
Copy link

nivekuil commented Apr 23, 2022 •
edited
Loading

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Description

Cannot filter for removing status in API.

It looks like restarting is missing too, haven't tried other statuses.

is-task seems to be a wrongfully invalid filter as well

Steps to reproduce the issue:

curl -g --unix-socket /run/podman/podman.sock 'http://d/v4.0.0/libpod/containers/json?filters={"status":["removing"]}'

Describe the results you received:
{"cause":"removing is not a valid status","message":"removing is not a valid status","response":500}

Describe the results you expected:
According to the docs this is a valid status: https://docs.podman.io/en/v4.0.0/_static/api.html#operation/ContainerListLibpod

Output of podman version:

Client:       Podman Engine
Version:      4.0.3
API Version:  4.0.3
Go Version:   go1.18
Git Commit:   62534053086fdeba7b93117e7c4dc6e797835a3e
Built:        Mon Apr  4 05:54:02 2022
OS/Arch:      linux/amd64
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 23, 2022
rhatdan added a commit to rhatdan/podman that referenced this issue Apr 24, 2022
@rhatdan
Removing is a valid status
b1c3752 
Do not use a list of statuses outside of libpod to validate container
statuses.  Removing status was never added to the list.

Fixes: containers#13986

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan added a commit to rhatdan/podman that referenced this issue Apr 24, 2022
@rhatdan
Allow filtering of "removing", it is a valid status
0d83f4b 
Do not use a list of statuses outside of libpod to validate container
statuses.  Removing status was never added to the list.

Fixes: containers#13986

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan mentioned this issue Apr 24, 2022
Merged
gbraad pushed a commit to gbraad-redhat/podman that referenced this issue Jul 13, 2022
@rhatdan
Allow filtering of "removing", it is a valid status
91eb738 
Do not use a list of statuses outside of libpod to validate container
statuses.  Removing status was never added to the list.

Fixes: containers#13986

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow filtering of "removing", it is a valid status rhatdan/podman
1 participant
@nivekuil