Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podman pod logs enhancements: option to display names #13261

Closed
muayyad-alsadi opened this issue Feb 17, 2022 · 4 comments · Fixed by #13362
Closed

podman pod logs enhancements: option to display names #13261

muayyad-alsadi opened this issue Feb 17, 2022 · 4 comments · Fixed by #13362
Assignees
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@muayyad-alsadi
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind feature

Description

the ability for podman pod logs -f to

  • an option to display names instead of ids
  • color different containers
  • follow new containers started after log started
  • do not exit if pod is empty (as long as pod is up, should not exit)

Steps to reproduce the issue:

podman pod create --name=pod_testlogs 
podman run --name=testlogs_loop1_1 -d --pod=pod_testlogs busybox /bin/sh -c 'for i in `seq 1 10000`; do echo "loop1: $i"; sleep 1; done'
podman run --name=testlogs_loop2_1 -d --pod=pod_testlogs busybox /bin/sh -c 'for i in `seq 1 10000`; do echo "loop2: $i"; sleep 3; done'
podman pod logs --tail=100 -f pod_testlogs

and then on another screen

podman run --name=testlogs_loop3_1 -d --pod=pod_testlogs busybox /bin/sh -c 'for i in `seq 1 10000`; do echo "loop3: $i"; sleep 3; done'

Describe the results you received:

  • ids instead of names
  • logs for loop3 is not followed
  • exit instantly when running podman pod logs --tail=100 -f pod_testlogs after podman pod create --name=pod_testlogs

Describe the results you expected:

  • away to display names and preferably colors
  • logs for loop3 should be followed
  • should not exit instantly when running podman pod logs --tail=100 -f pod_testlogs after podman pod create --name=pod_testlogs
@openshift-ci openshift-ci bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 17, 2022
@rhatdan rhatdan added the Good First Issue This issue would be a good issue for a first time contributor to undertake. label Feb 17, 2022
@rhatdan
Copy link
Member

rhatdan commented Feb 17, 2022

Seems reasonable to me, although breaking these into multiple RFEs might make it easier to consume and deliver.
I think podman logs --names ...

Should be fairly easy to add.

@muayyad-alsadi muayyad-alsadi changed the title podman pod logs enhancements podman pod logs enhancements: option to display names Feb 17, 2022
@muayyad-alsadi
Copy link
Contributor Author

multiple RFEs

thank you, I've just did that.

@keonchennl
Copy link

keonchennl commented Feb 26, 2022

Hi May I work on this? I am also in this student team.

@rhatdan
Copy link
Member

rhatdan commented Feb 26, 2022

Yes @keonchennl I assigned it to you.

keonchennl added a commit to keonchennl/podman that referenced this issue Feb 28, 2022
Fixes containers#13261

Signed-off-by: Xueyuan Chen <X.Chen-47@student.tudelft.nl>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good First Issue This issue would be a good issue for a first time contributor to undertake. kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants